Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jun 25, 2024

What changes were proposed in this pull request?

The pr aims to fix Python CodeGen check.
https://github.com/panbingkun/spark/actions/runs/9647082015/job/26605246479#logs
image

Why are the changes needed?

Make Python CodeGen check happy.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Pass GA.
  • Manually test
python3.9 ./dev/connect-check-protos.py
...
+ cp gen/proto/python/spark/connect/types_pb2.py /var/folders/mb/yhrmjn4d44n5vp67_gbj8rh00000gn/T/check_connect_protos6tr54fq4
+ rm -Rf gen
Finish checking the generated codes in pyspark-connect: SUCCESS

Was this patch authored or co-authored using generative AI tooling?

No.

@panbingkun panbingkun changed the title Fix Python Codegen Check [SPARK-48702][INFRA] Fix Python CodeGen check Jun 25, 2024
@panbingkun panbingkun marked this pull request as ready for review June 25, 2024 00:39
@panbingkun
Copy link
Contributor Author

cc @HyukjinKwon @zhengruifeng

@HyukjinKwon
Copy link
Member

Merged to master.

@zhengruifeng
Copy link
Contributor

Late LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants