[SPARK-47927][SQL][FOLLOWUP] fix ScalaUDF output nullability (alternative fix) #47085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the rule HandleNullInputsForUDF ScalaUDF will propagate null for primitive types. The problem is that this is currently not reflected in the implementation of `nullable` for ScalaUDF. This currently leads to wrong nullability of the result in some cases. This patch fixes this by making the implemenation of `nullable` for ScalaUDF reflect that it propages null for primitive types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Alternative fix to the one suggested in #47081
Because of the rule HandleNullInputsForUDF ScalaUDF will propagate null for primitive types. The problem is that this is currently not reflected in the implementation of
nullablefor ScalaUDF. This currently leads to wrong nullability of the result in some cases. This patch fixes this by making the implemenation ofnullablefor ScalaUDF reflect that it propages null for primitive types.Why are the changes needed?
Fix nullability.
Does this PR introduce any user-facing change?
Yes, fixes nullability.
How was this patch tested?
New and existing tests.
Was this patch authored or co-authored using generative AI tooling?
No,