[SPARK-48713][SQL] Add index range check for UnsafeRow.pointTo when baseObject is byte array #47087
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngone51
changed the title
cloud-fan
reviewed
Jun 25, 2024
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jun 25, 2024
cloud-fan
approved these changes
Jun 26, 2024
yaooqinn
approved these changes
Jun 26, 2024
Member
|
Merged to master, thank you @Ngone51 @cloud-fan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add a index range check for
UnsafeRow.pointTo()whenbaseObjectis byte array.Why are the changes needed?
All the other places like
readExternal(),read()ensuressizeInBytescan't be larger than the lenght ofbaseObjectwhen it is a byte array excepetpointTo(). So adding this check helps us to get better error stack info in the first place when the index went wrong.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unit test.
Was this patch authored or co-authored using generative AI tooling?
No.