Skip to content

Conversation

@anchovYu
Copy link
Contributor

@anchovYu anchovYu commented Jun 25, 2024

What changes were proposed in this pull request?

A followup for https://github.com/apache/spark/pull/41554/files.
Handle the case when the deserializer in cogroup is resolved when applying DeduplicateRelation rule. Otherwise, it will throw an uncastable error.
See the added test case as an example.

Why are the changes needed?

Fix a bug introduced in a previous commit.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Add a new test case.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Jun 25, 2024
@anchovYu anchovYu changed the title [WIP]fix [SQL] Handle and fix the case when deserializer in cogroup is resolved during application of DeduplicateRelation rule Jun 25, 2024
@HyukjinKwon
Copy link
Member

Let's file a JIRA

@anchovYu
Copy link
Contributor Author

Let's file a JIRA

yesyes

@anchovYu anchovYu changed the title [SQL] Handle and fix the case when deserializer in cogroup is resolved during application of DeduplicateRelation rule [SPARK-48718][SQL] Handle and fix the case when deserializer in cogroup is resolved during application of DeduplicateRelation rule Jun 26, 2024
@cloud-fan
Copy link
Contributor

cloud-fan commented Jun 26, 2024

Test passed except for unrelated docker failures, and the last commit just renames a test. Thanks, merging to master!

@cloud-fan cloud-fan closed this in ebacb91 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants