Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jun 26, 2024

What changes were proposed in this pull request?

The pr is following up #46845, to fix dev/scalastyle check error.

Why are the changes needed?

Make sh dev/scalastyle happy.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually test

sh dev/scakastyle

Before:

(base) ➜  spark-community git:(master) ✗ sh dev/scalastyle
-e Scalastyle checks failed at following occurrences:
[error] /Users/panbingkun/Developer/spark/spark-community/sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/ExpressionImplUtilsSuite.scala:394:28: nonascii.message
[error] /Users/panbingkun/Developer/spark/spark-community/sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/ExpressionImplUtilsSuite.scala:396:28: nonascii.message
[error] Total time: 23 s, completed Jun 26, 2024, 9:49:06 AM

After:

(base) ➜  spark-community git:(fix_scalastyle) ✗ sh dev/scalastyle
-e Scalastyle checks passed.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Jun 26, 2024
@panbingkun panbingkun marked this pull request as ready for review June 26, 2024 01:43
@panbingkun
Copy link
Contributor Author

cc @HyukjinKwon @cloud-fan @uros-db

@panbingkun panbingkun changed the title [MINOR] Fix CodeStyle Error for ExpressionImplUtilsSuite [SPARK-48578][SQL][FOLLOWUP] Fix dev/scalastyle error for ExpressionImplUtilsSuite Jun 26, 2024
Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@cloud-fan
Copy link
Contributor

let me merge it now to unblock the CI.

@cloud-fan cloud-fan closed this in 169346c Jun 26, 2024
Copy link
Contributor

@uros-db uros-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit late to the party, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants