Skip to content

[SPARK-48735][SQL] Performance Improvement for BIN function #47119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 7 commits into from
Closed

[SPARK-48735][SQL] Performance Improvement for BIN function #47119

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47c7a55
improvment
yaooqinn Jun 27, 2024
2544a84
comments
yaooqinn Jun 27, 2024
58d5870
fix
yaooqinn Jun 27, 2024
d43789f
add benchmark
yaooqinn Jun 27, 2024
364537d
add benchmark
yaooqinn Jun 27, 2024
d4d20f0
Revert "add benchmark"
yaooqinn Jun 27, 2024
21ace11
Revert "add benchmark"
yaooqinn Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comments
  • Loading branch information
@yaooqinn
yaooqinn committed Jun 27, 2024
commit 2544a844dcab691e89745c48d1c1a4c72b1c657f
13 changes: 8 additions & 5 deletions common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1869,18 +1869,21 @@ public void read(Kryo kryo, Input in) {
in.read((byte[]) base);
}

/**
* Convert a long value to its binary format stripping leading zeros.
*/
public static UTF8String toBinaryString(long val) {
int zeros = Long.numberOfLeadingZeros(val);
if (zeros == Long.SIZE) {
return UTF8String.ZERO_UTF8;
} else {
int length = Math.max(Long.SIZE - Long.numberOfLeadingZeros(val), 1);
byte[] buf = new byte[length];
int length = Long.SIZE - Long.numberOfLeadingZeros(val);
byte[] bytes = new byte[length];
do {
buf[--length] = (byte) ((val & 0x1) == 1 ? '1': '0');
bytes[--length] = (byte) ((val & 0x1) == 1 ? '1': '0');
val >>>= 1;
} while(length > 0);
return fromBytes(buf);
} while (length > 0);
return fromBytes(bytes);
}
}
}