[SPARK-48736][PYTHON] Support infra fro additional includes for Python UDFs #47120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jun 27, 2024
HyukjinKwon
changed the title
allisonwang-db
approved these changes
Jun 27, 2024
Contributor
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Would be good to also have a test for this.
Member
|
Agree with adding a test. Maybe there would be a separate PR that actually uses this message with e2e test. I will defer to it, and merge it first :-). Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The interface of the SimplePython function already supports specifying additional includes. However, the proto for the clients and the handling in the planner has been missing. This patch simply adds the base infrastructure for that.
Why are the changes needed?
Compatibility
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT
Was this patch authored or co-authored using generative AI tooling?
No