Skip to content

[SPARK-48737] Perf improvement during analysis - Create exception only when it is necessary for default expression resolving #47124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
urosstan-db wants to merge 2 commits into from
Closed

[SPARK-48737] Perf improvement during analysis - Create exception only when it is necessary for default expression resolving #47124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a923487
Create exception only when it is neccessary
urosstan-db Jun 27, 2024
8093c8a
Update ResolveDefaultColumnsUtil.scala
cloud-fan Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Create exception only when it is neccessary
  • Loading branch information
@urosstan-db
urosstan-db committed Jun 27, 2024
commit a923487b1bdb8672c0e6feabf18bb5d9eac830e9
6 changes: 5 additions & 1 deletion ...atalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,15 @@ object ResolveDefaultColumns extends QueryErrorsBase
*
* The column "DEFAULT" will be resolved to the default value expression defined for the column of
* the assignment key.
*
* IMPORTANT: The 'invalidColumnDefaultException' argument must be lazy until the exception
* is actually thrown, because the instantiation of SparkThrowable exception results in
* reading the file error-classes to format exception message.
*/
def resolveColumnDefaultInAssignmentValue(
key: Expression,
value: Expression,
invalidColumnDefaultException: Throwable): Expression = {
invalidColumnDefaultException: => Throwable): Expression = {
key match {
case attr: AttributeReference =>
value match {
Expand Down