Skip to content

[SPARK-47233][CONNECT][SS][FOLLOW-UP] Add eventually for terminated event assert #47139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-47233][CONNECT][SS][FOLLOW-UP] Add eventually for terminated event assert #47139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python/pyspark/sql/tests/connect/streaming/test_parity_listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from pyspark.sql.streaming.listener import StreamingQueryListener
from pyspark.sql.functions import count, lit
from pyspark.testing.connectutils import ReusedConnectTestCase
from pyspark.testing.utils import eventually


# Listeners that has spark commands in callback handler functions
Expand Down Expand Up @@ -160,8 +161,12 @@ def test_slow_query(self):
self.assertTrue(slow_query.id in [str(e.progress.id) for e in listener.progress])
self.assertTrue(fast_query.id in [str(e.progress.id) for e in listener.progress])

self.assertTrue(slow_query.id in [str(e.id) for e in listener.terminated])
self.assertTrue(fast_query.id in [str(e.id) for e in listener.terminated])
eventually(timeout=20, catch_assertions=True)(
lambda: self.assertTrue(slow_query.id in [str(e.id) for e in listener.terminated])
)()
eventually(timeout=20, catch_assertions=True)(
lambda: self.assertTrue(fast_query.id in [str(e.id) for e in listener.terminated])
)()

finally:
for listener in self.spark.streams._sqlb._listener_bus:
Expand Down