Skip to content

[SPARK-48623][CORE] Structured logging migrations [Part 3] #47275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asl3 wants to merge 12 commits into from
Closed

[SPARK-48623][CORE] Structured logging migrations [Part 3] #47275

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7c73c4b
more structured log migration
asl3 Jul 9, 2024
ca8360b
style fixes
asl3 Jul 9, 2024
025c5d0
revise logging messages
asl3 Jul 9, 2024
16fe384
logkey modifications
asl3 Jul 9, 2024
bf6c2e0
remove unused logkeys
asl3 Jul 9, 2024
44c8172
fix
gengliangwang Jul 10, 2024
ebf39c6
scalafmt
asl3 Jul 10, 2024
5b67ffd
style fix
asl3 Jul 10, 2024
6f77d42
reformat
asl3 Jul 10, 2024
26466df
Merge branch 'master' into formatstructuredlogmigrations
asl3 Jul 11, 2024
3cb85ba
style fix
asl3 Jul 11, 2024
215d149
scalafmt
asl3 Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
scalafmt
  • Loading branch information
@asl3
asl3 committed Jul 11, 2024
commit 215d149de7143bb4b1d30c30428840bdd5548c22
10 changes: 6 additions & 4 deletions connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,12 @@ case class SessionHolder(userId: String, sessionId: String, session: SparkSessio
// memorizing `LogicalPlan`s which may be a sub-tree in a subsequent plan.
private lazy val planCache: Option[Cache[proto.Relation, LogicalPlan]] = {
if (SparkEnv.get.conf.get(Connect.CONNECT_SESSION_PLAN_CACHE_SIZE) <= 0) {
logWarning(log"Session plan cache is disabled due to non-positive cache size." +
log" Current value of '${MDC(LogKeys.CONFIG,
Connect.CONNECT_SESSION_PLAN_CACHE_SIZE.key)}' is ${MDC(LogKeys.CACHE_SIZE,
SparkEnv.get.conf.get(Connect.CONNECT_SESSION_PLAN_CACHE_SIZE))}")
logWarning(
log"Session plan cache is disabled due to non-positive cache size." +
log" Current value of " +
log"'${MDC(LogKeys.CONFIG, Connect.CONNECT_SESSION_PLAN_CACHE_SIZE.key)}' is ${MDC(
LogKeys.CACHE_SIZE,
SparkEnv.get.conf.get(Connect.CONNECT_SESSION_PLAN_CACHE_SIZE))}")
None
} else {
Some(
Expand Down