Skip to content

SPARK-1544 Add support for deep decision trees. #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manishamde wants to merge 22 commits into from
Closed

SPARK-1544 Add support for deep decision trees. #475

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
50b143a
adding support for very deep trees
manishamde Apr 20, 2014
abc5a23
Parameterizing max memory.
etrain Apr 22, 2014
2f6072c
Merge pull request #5 from etrain/deep_tree
manishamde Apr 22, 2014
2f1e093
minor: added doc for maxMemory parameter
manishamde Apr 22, 2014
0287772
Fixing scalastyle issue.
etrain Apr 22, 2014
fecf89a
Merge pull request #6 from etrain/deep_tree
manishamde Apr 22, 2014
719d009
updating user documentation
manishamde Apr 24, 2014
9dbdabe
merge from master
manishamde Apr 29, 2014
1517155
updated documentation
manishamde Apr 29, 2014
718506b
added unit test
manishamde Apr 30, 2014
e0426ee
renamed parameter
manishamde May 1, 2014
dad9652
removed unused imports
manishamde May 1, 2014
cbd9f14
modified scala.math to math
manishamde May 3, 2014
5e82202
added documentation, fixed off by 1 error in max level calculation
manishamde May 6, 2014
4731cda
formatting
manishamde May 6, 2014
5eca9e4
grammar
manishamde May 6, 2014
8053fed
more formatting
manishamde May 6, 2014
426bb28
programming guide blurb
manishamde May 6, 2014
b27ad2c
formatting
manishamde May 6, 2014
ce004a1
minor formatting
manishamde May 6, 2014
7fc9545
added docs
manishamde May 7, 2014
968ca9d
merged master
manishamde May 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added docs
  • Loading branch information
@manishamde
manishamde committed May 7, 2014
commit 7fc95457ec66023ddf14e0ef3e1e18cbf828a4db
2 changes: 2 additions & 0 deletions mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,8 @@ object DecisionTree extends Serializable with Logging {
* @param filters Filters for all nodes at a given level
* @param splits possible splits for all features
* @param bins possible bins for all features
* @param numGroups total number of node groups at the current level. Default value is set to 1.
* @param groupIndex index of the node group being processed. Default value is set to 0.
* @return array of splits with best splits for all nodes at a given level.
Copy link
Contributor

@mengxr mengxr May 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docs for numGroups and groupIndex.

Copy link
Contributor Author

@manishamde manishamde May 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mengxr I already added more documentation. Is there something more I am missing here?

Copy link
Contributor

@mengxr mengxr May 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the docs of numGroups and groupIndex.

*/
private def findBestSplitsPerGroup(
Expand Down