Skip to content

Conversation

@andrusha
Copy link
Contributor

@andrusha andrusha commented Aug 8, 2024

SQL API docs show incorrect since field as 1.5.0: https://spark.apache.org/docs/latest/api/sql/#named_struct

While the named structs were actually added since 3.5.0: https://issues.apache.org/jira/browse/SPARK-43926

de8ec74

What changes were proposed in this pull request?

The correct since field is set on the named_struct method to be reflected in documentation.

Why are the changes needed?

Documentation should reflect the actual feature availability.

Does this PR introduce any user-facing change?

It is a documentation fix.

How was this patch tested?

No tests are needed.

Was this patch authored or co-authored using generative AI tooling?

No

SQL API docs show incorrect `since` field as 1.5.0:
https://spark.apache.org/docs/latest/api/sql/#named_struct

While the named structs were actually added since 3.5.0:
https://issues.apache.org/jira/browse/SPARK-43926

apache@de8ec74
@github-actions github-actions bot added the SQL label Aug 8, 2024
@andrusha
Copy link
Contributor Author

andrusha commented Aug 8, 2024

@maropu could you take a look?

@wayneguow
Copy link
Contributor

The ticket(https://issues.apache.org/jira/browse/SPARK-43926) that you mentioned is used to support named_struct to be used in APIs such as Scala or Python, but in SQL, it was actually implemented a long time ago, refer to PR #6874, so I think this is not a problem.

@HyukjinKwon
Copy link
Member

Yeah it was already there before.

@andrusha
Copy link
Contributor Author

Aha, makes sense, then I was confused by the docs structure expecting all SQL functions to be available in their Scala dataframe equivalent

@andrusha andrusha closed this Aug 10, 2024
@andrusha andrusha deleted the patch-2 branch August 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants