[SPARK-49210][SQL] Support driver metrics for DS v2 write #47717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cloud-fan @viirya @dongjoon-hyun Can you help with the review? Thanks |
Contributor
|
Sorry I missed this. #48573 did the same thing, and I think it's simpler to have separate APIs for Scan and Write, instead of adding a common interface for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support driver metrics for DS v2 write
Why are the changes needed?
For v2 tables like iceberg or paimon, its write metrics are very useful, by supporting driver metrics, we can report commit time, commited files, snapshot id etc.
Does this PR introduce any user-facing change?
Extract common interface
SupportCustomMetricsforwriteandscanHow was this patch tested?
Add test case for writing v2 and v1 fallback table
Was this patch authored or co-authored using generative AI tooling?
No