Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Incorporate changes
  • Loading branch information
mihailomilosevic2001 committed Nov 13, 2024
commit fb34be0b0f58e07c198d7cb19e98bcf586cbf82c
Original file line number Diff line number Diff line change
Expand Up @@ -1723,7 +1723,7 @@ case class DateAddInterval(
override def nullSafeEval(start: Any, interval: Any): Any = {
val itvl = interval.asInstanceOf[CalendarInterval]
if (ansiEnabled || itvl.microseconds == 0) {
DateTimeUtils.dateAddInterval(start.asInstanceOf[Int], itvl, prettyName)
DateTimeUtils.dateAddInterval(start.asInstanceOf[Int], itvl)
} else {
val startTs = DateTimeUtils.daysToMicros(start.asInstanceOf[Int], zoneId)
val resultTs = DateTimeUtils.timestampAddInterval(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,9 @@ object DateTimeUtils extends SparkDateTimeUtils {
*/
def dateAddInterval(
start: Int,
interval: CalendarInterval,
funcName: String): Int = {
interval: CalendarInterval): Int = {
if (interval.microseconds != 0) {
throw QueryExecutionErrors.invalidIntervalWithMicrosecondsAdditionError(funcName)
throw QueryExecutionErrors.invalidIntervalWithMicrosecondsAdditionError()
}
val ld = daysToLocalDate(start).plusMonths(interval.months).plusDays(interval.days)
localDateToDays(ld)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,7 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
summary = "")
}

def invalidIntervalWithMicrosecondsAdditionError(
funcName: String): SparkIllegalArgumentException = {
def invalidIntervalWithMicrosecondsAdditionError(): SparkIllegalArgumentException = {
new SparkIllegalArgumentException(
errorClass = "INVALID_INTERVAL_WITH_MICROSECONDS_ADDITION",
messageParameters = Map("ansiConfig" -> toSQLConf(SQLConf.ANSI_ENABLED.key)))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -536,12 +536,12 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {

test("date add interval with day precision") {
val input = days(1997, 2, 28)
assert(dateAddInterval(input, new CalendarInterval(36, 0, 0), "") === days(2000, 2, 28))
assert(dateAddInterval(input, new CalendarInterval(36, 47, 0), "") === days(2000, 4, 15))
assert(dateAddInterval(input, new CalendarInterval(-13, 0, 0), "") === days(1996, 1, 28))
assert(dateAddInterval(input, new CalendarInterval(36, 0, 0)) === days(2000, 2, 28))
assert(dateAddInterval(input, new CalendarInterval(36, 47, 0)) === days(2000, 4, 15))
assert(dateAddInterval(input, new CalendarInterval(-13, 0, 0)) === days(1996, 1, 28))
checkError(
exception = intercept[SparkIllegalArgumentException](
dateAddInterval(input, new CalendarInterval(36, 47, 1), "test")),
dateAddInterval(input, new CalendarInterval(36, 47, 1))),
condition = "INVALID_INTERVAL_WITH_MICROSECONDS_ADDITION",
parameters = Map("ansiConfig" -> "\"spark.sql.ansi.enabled\""))
}
Expand Down