-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-50066][SQL] Codegen Support for SchemaOfXml (by Invoke & RuntimeReplaceable)
#48594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c287770
[SPARK-50066][SQL] Codegen Support for `SchemaOfXml` (by Invoke & Run…
panbingkun a389d89
add XmlExpressionEvalUtils
panbingkun f0df6c0
Merge branch 'master' into SPARK-50066
panbingkun 637bd3a
Merge branch 'master' into SPARK-50066
panbingkun efe2a11
update
panbingkun 4ab91ec
update
panbingkun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update
- Loading branch information
commit efe2a11fb5596c0205964c2c3412857fefede1b9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should set
returnNullableto false, otherwise it's a regression.SchemaOfXml#nullablealways return false.cc @panbingkun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I have fixed this issue with followup #48987. I think
scheme_of_xml,schema_of_csvandschema_of_jsonhas similar issues, so I will fix them all at once.Thanks!