Skip to content

[SPARK-6141][MLlib] Upgrade Breeze from 0.10 to 0.11 to fix convergence bug #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbtsai wants to merge 4 commits into from
Closed

[SPARK-6141][MLlib] Upgrade Breeze from 0.10 to 0.11 to fix convergence bug #4879

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
397a208
upgrade breeze
Mar 3, 2015
35c2f26
fix LRSuite
mengxr Mar 3, 2015
c2ca6ac
upgrade to breeze-0.11.1
mengxr Mar 3, 2015
d848f65
Merge pull request #1 from mengxr/AlpineNow-breeze
dbtsai Mar 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<dependency>
<groupId>org.scalanlp</groupId>
<artifactId>breeze_${scala.binary.version}</artifactId>
<version>0.11</version>
<version>0.11.1</version>
<exclusions>
<!-- This is included as a compile-scoped dependency by jtransforms, which is
a dependency of breeze. -->
Expand Down
4 changes: 4 additions & 0 deletions mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,12 @@ class LogisticRegressionSuite extends FunSuite with MLlibTestSparkContext with M
testRDD2.cache()
testRDD3.cache()

val numIteration = 10

val lrA = new LogisticRegressionWithLBFGS().setIntercept(true)
lrA.optimizer.setNumIterations(numIteration)
val lrB = new LogisticRegressionWithLBFGS().setIntercept(true).setFeatureScaling(false)
lrB.optimizer.setNumIterations(numIteration)

val modelA1 = lrA.run(testRDD1, initialWeights)
val modelA2 = lrA.run(testRDD2, initialWeights)
Expand Down