[SPARK-50309][DOCS] Document SQL Pipe Syntax
#48852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtenedor
changed the title
Contributor
Author
|
cc @cloud-fan @gengliangwang here is documentation support for the new SQL pipe syntax, which is nearly completed. |
Member
|
@dtenedor The doc looks good to me overall. |
Contributor
Author
|
@gengliangwang thanks for your review! I updated the docs with more examples and information per recommendation, please take another look. |
cloud-fan
reviewed
Nov 15, 2024
docs/sql-pipe-syntax.md
Outdated
| #### LIMIT | ||
|
|
||
| ```sql | ||
| |> LIMIT <n> [OFFSET <m>] |
Contributor
There was a problem hiding this comment.
is OFFSET m LIMIT n allowed?
Contributor
Author
There was a problem hiding this comment.
@cloud-fan I checked, and OFFSET is allowed without LIMIT, and vice versa. But if both are present, LIMIT must come before OFFSET. Updated this part accordingly.
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
SQL Pipe Syntax
MaxGekk
approved these changes
Nov 15, 2024
Member
|
Thanks, merging to master |
dongjoon-hyun
added a commit
that referenced
this pull request
Dec 7, 2024
…x.md` ### What changes were proposed in this pull request? This PR aims to fix invalid `CREATE TABLE` syntax in `sql-pipe-syntax.md`. It seems that we missed during documentation. It causes `ParseException: Operation not allowed` . - #48852 ### Why are the changes needed? The current documentation is here. - https://apache.github.io/spark/sql-pipe-syntax.html#from-or-table **BEFORE** ``` spark-sql (default)> CREATE TABLE t(col INT) AS VALUES (0), (1); Operation not allowed: Schema may not be specified in a Create Table As Select (CTAS) statement. == SQL (line 1, position 1) == CREATE TABLE t(col INT) AS VALUES (0), (1) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` **AFTER** ``` spark-sql (default)> CREATE TABLE t AS VALUES (0), (1); Time taken: 0.142 seconds spark-sql (default)> TABLE t; 1 0 Time taken: 0.287 seconds, Fetched 2 row(s) ``` ### Does this PR introduce _any_ user-facing change? No, this is a documentation-only change of the unreleased SQL Pipe syntax. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49096 from dongjoon-hyun/SPARK-50512. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds documentation for SQL pipe syntax.
Why are the changes needed?
It provides a reference table of available operators and describes how the syntax works in each of the supported circumstances.
Does this PR introduce any user-facing change?
No, this is a documentation-only change.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No