Skip to content

[SPARK-6145] [SQL] Fix the bug of nested data type resolving in ORDER BY #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenghao-intel wants to merge 6 commits into from
Closed

[SPARK-6145] [SQL] Fix the bug of nested data type resolving in ORDER BY #4892

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b82c8c5
fix the bug of nested data type resolving in sort by
chenghao-intel Mar 4, 2015
44ac17d
nested a.a.a which returns expression with alias name 'a'
chenghao-intel Mar 5, 2015
47db754
fix the bug in unittest
chenghao-intel Mar 5, 2015
5de3b9e
fix another bug in unittest
chenghao-intel Mar 5, 2015
73eb346
update the output column attribute name for nested data query
chenghao-intel Mar 5, 2015
9209ac1
update as feedback
chenghao-intel Mar 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix the bug of nested data type resolving in sort by
  • Loading branch information
@chenghao-intel
chenghao-intel committed Mar 4, 2015
commit b82c8c5c8a743860b718f3a4bddeb08fd08bdcb8
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ class SqlParser extends AbstractSparkSQLParser {

protected lazy val dotExpressionHeader: Parser[Expression] =
(ident <~ ".") ~ ident ~ rep("." ~> ident) ^^ {
case i1 ~ i2 ~ rest => UnresolvedAttribute(i1 + "." + i2 + rest.mkString(".", ".", ""))
case i1 ~ i2 ~ rest => UnresolvedAttribute((Seq(i1, i2) ++ rest).mkString("."))
Copy link
Contributor Author

@chenghao-intel chenghao-intel Mar 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

val i1="a"
val i2="b"
val rest:Seq[String]=Nil
println(i1 + "." + i2 + rest.mkString(".", ".", ""))

outputs a.b., what we expect is a.b

Copy link
Contributor

@cloud-fan cloud-fan Mar 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my mistake...didn't test the mkString method on Nil

Copy link
Contributor

@adrian-wang adrian-wang Mar 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about
UnresolvedAttribute(i1 + "." + i2 + rest.mkString("."))

Copy link
Contributor Author

@chenghao-intel chenghao-intel Mar 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

val i1="a"
val i2="b"
val rest:Seq[String]="c" :: Nil
println(i1 + "." + i2 + rest.mkString("."))

Outputs a.bc

Copy link
Contributor

@adrian-wang adrian-wang Mar 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That make sense, thanks!

}

protected lazy val dataType: Parser[DataType] =
Expand Down
6 changes: 5 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,12 @@ class Analyzer(catalog: Catalog,
case s @ Sort(ordering, global, p @ Project(projectList, child))
if !s.resolved && p.resolved =>
val unresolved = ordering.flatMap(_.collect { case UnresolvedAttribute(name) => name })
// TODO child.resolve maybe not resolve all of the nested data at once
val resolved = unresolved.flatMap(child.resolve(_, resolver))
val requiredAttributes = AttributeSet(resolved.collect { case a: Attribute => a })
val requiredAttributes = AttributeSet(resolved.collect {
case a: Attribute => a
case a: NamedExpression if a.resolved == false => a
})

val missingInProject = requiredAttributes -- p.output
if (missingInProject.nonEmpty) {
Expand Down
9 changes: 9 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ class SQLQuerySuite extends QueryTest with BeforeAndAfterAll {
)
}

test("SPARK-6145 order by the nested data") {
sqlCtx.jsonRDD(sqlCtx.sparkContext.parallelize(
"""{"a": {"b": {"d": 1}}, "c": 1}""" :: Nil)).registerTempTable("nestedOrder")

checkAnswer(sqlCtx.sql("SELECT 1 FROM nestedOrder ORDER BY c"), Row(1))
checkAnswer(sqlCtx.sql("SELECT 1 FROM nestedOrder ORDER BY a.b.d"), Row(1))
checkAnswer(sqlCtx.sql("SELECT a.b.d FROM nestedOrder ORDER BY a.b.d"), Row(1))
}

test("grouping on nested fields") {
jsonRDD(sparkContext.parallelize("""{"nested": {"attribute": 1}, "value": 2}""" :: Nil))
.registerTempTable("rows")
Expand Down