Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Mar 5, 2015

logDebug messages in ResolveSortReferences are incorrectly placed. This pr fixes it. Besides, directly using p.output instead of projectList.map(_.toAttribute).

@SparkQA
Copy link

SparkQA commented Mar 5, 2015

Test build #28283 has finished for PR 4905 at commit a94e8c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@chenghao-intel
Copy link
Contributor

LTGM, but is it possible go after #4892 ? :)

@chenghao-intel
Copy link
Contributor

Hopefully this PR doesn't conflict with #4892

@viirya
Copy link
Member Author

viirya commented Mar 5, 2015

@chenghao-intel Thanks! Looks like they shouldn't conflict.

@viirya
Copy link
Member Author

viirya commented Mar 6, 2015

CC @marmbrus.

@viirya
Copy link
Member Author

viirya commented Mar 17, 2015

/cc @marmbrus

@marmbrus
Copy link
Contributor

I'm not really sure I would say these debugging messages are in the "wrong place". They are in the place that they needed to be when I was debugging this code, and they aren't really intended for anything other than that. The change to use .output instead is more concise, but is a no-op. While its good to have simple code, there is a limited amount of time that can be spent reviewing and merging PRs and I'd rather most PRs came with test cases that were failing previously and are now fixed.

@viirya
Copy link
Member Author

viirya commented Mar 18, 2015

ok. let's close this.

@viirya viirya closed this Mar 18, 2015
@viirya viirya deleted the fix_resolversort_log branch December 27, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants