[SPARK-50603][SQL] Respect user-provided basePath for streaming file source reads without glob #49220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@viirya since this was your original bug fix (although 8 years ago) |
viirya
approved these changes
Dec 18, 2024
Contributor
Author
|
Re-ran the failed workflow job to get it to pass |
Member
|
LGTM |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Kimahriman
force-pushed
the
respect-base-path
branch
from
9d3ec57 to
b0b9cf8
Compare
Contributor
Author
|
@HyukjinKwon simple fix if you could reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't override the user-provided
basePathfor streaming file source reads without globbing.Why are the changes needed?
#14803 fixed an issue reading partition values for streaming file source reads without globbing, but it always overwrites the
basePathoption. If the user provides a custombasePathin this case, there can be a mismatch in partition schema from when the stream is loaded to when a batch is executed, causing errors.Does this PR introduce any user-facing change?
Bug fix.
How was this patch tested?
New UT
Was this patch authored or co-authored using generative AI tooling?
No