[SPARK-51820][SQL][FOLLOWUP] Fix origin for UnresolvedOrdinal
#50676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Apr 23, 2025
Contributor
|
thanks, merging to master! |
| expression: Expression, | ||
| canReplaceWithOrdinal: Boolean = true) = expression match { | ||
| case Literal(value: Int, IntegerType) if canReplaceWithOrdinal => UnresolvedOrdinal(value) | ||
| case literal @ Literal(value: Int, IntegerType) if canReplaceWithOrdinal => |
Contributor
There was a problem hiding this comment.
Should we do the same in sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala?
Contributor
There was a problem hiding this comment.
Please make a followup PR for this (per offline discussion with @cloud-fan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup to #50606 to fix the origin and context of newly created
UnresolvedOrdinal.Why are the changes needed?
Origin and context of
UnresolvedOrdinalshould be the same as for the originalLiteral.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No