[SPARK-51899][SQL] Implement error handling rules for spark.catalog.listTables() #50696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyihong
changed the title
heyihong
force-pushed
the
SPARK-51899
branch
2 times, most recently
from
fa1f6f1 to
65dd133
Compare
heyihong
changed the title
HyukjinKwon
reviewed
Apr 24, 2025
Member
There was a problem hiding this comment.
The change seems good but shouldn't we still keep this though? Other exceptions might happen that doesn't inherit SparkThrowable.
Contributor
Author
There was a problem hiding this comment.
There are risks associated with working with partial data, especially when unaware that some tables are broken. Throwing an exception instead provides a clear indication that something is wrong.
We should still do some exception handling here, but we need to determine the proper behavior on a case-by-case basis. SparkThrowable should be sufficient to capture the cases we want to handle.
heyihong
force-pushed
the
SPARK-51899
branch
2 times, most recently
from
1be13f7 to
71792d8
Compare
heyihong
changed the title
heyihong
changed the title
cloud-fan
approved these changes
Apr 28, 2025
Contributor
|
thanks, merging to master! |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…istTables() ### What changes were proposed in this pull request? - Revert apache#50515 - Implement error handling rules based on error conditions for Spark errors in spark.catalog.listTables(). ### Why are the changes needed? There are risks associated with working with partial data, especially when unaware that some tables are broken. Throwing an exception instead provides a clear indication that something is wrong. Instead we can use error handling rules to determine the proper behavior on a case-by-case basis. SparkThrowable should be sufficient to capture the cases we want to handle. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests (e.g. `build/sbt "sql/testOnly *CatalogSuite"`, `build/sbt "hive/testOnly *HiveDDLSuite"`) ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50696 from heyihong/SPARK-51899. Authored-by: Yihong He <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
There are risks associated with working with partial data, especially when unaware that some tables are broken. Throwing an exception instead provides a clear indication that something is wrong.
Instead we can use error handling rules to determine the proper behavior on a case-by-case basis. SparkThrowable should be sufficient to capture the cases we want to handle.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests (e.g.
build/sbt "sql/testOnly *CatalogSuite",build/sbt "hive/testOnly *HiveDDLSuite")Was this patch authored or co-authored using generative AI tooling?
No