[SPARK-51820][SQL][CONNECT] Address remaining issues for new group/order by ordinal approach
#50699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailotim-db
force-pushed
the
mihailotim-db/fix_ordinal_followup
branch
5 times, most recently
from
206a6fc to
bad8633
Compare
mihailotim-db
changed the title
group/order by ordinal approach
mihailotim-db
force-pushed
the
mihailotim-db/fix_ordinal_followup
branch
from
bad8633 to
6aee218
Compare
Contributor
|
IIUC we changed the API/approach for functions that explicitly add |
Contributor
|
We should check all DataFrame APIs, but |
cloud-fan
reviewed
Apr 28, 2025
sql/core/src/test/scala/org/apache/spark/sql/ReplaceIntegerLiteralsWithOrdinalsSuite.scala
Outdated
Show resolved
Hide resolved
mihailotim-db
force-pushed
the
mihailotim-db/fix_ordinal_followup
branch
3 times, most recently
from
b4d1ed0 to
1003a53
Compare
cloud-fan
approved these changes
Apr 28, 2025
Contributor
|
@cloud-fan Agree that |
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala
Outdated
Show resolved
Hide resolved
...connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Outdated
Show resolved
Hide resolved
...e/src/test/scala/org/apache/spark/sql/ReplaceIntegerLiteralsWithOrdinalsDataframeSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mihailoale-db We are only interested in what happens in early batches (before |
mihailotim-db
force-pushed
the
mihailotim-db/fix_ordinal_followup
branch
from
1003a53 to
1d4925f
Compare
mihailotim-db
force-pushed
the
mihailotim-db/fix_ordinal_followup
branch
from
1d4925f to
927bdc8
Compare
Contributor
|
thanks, merging to master! |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…`order` by ordinal approach ### What changes were proposed in this pull request? This is a followup to apache#50606, to address remaining issues in fixed-point analyzer and parser. This PR does the following: 1. Set correct origin in `SparkConnect` and `Dataframe` API 2. Handle remaining cases for order by ordinal in `Dataframe` API 3. Add a test suite for Dataframe use cases since we are missing those ### Why are the changes needed? To address current issue with `UnresolvedOrdinal` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a new test suite and existing tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50699 from mihailotim-db/mihailotim-db/fix_ordinal_followup. Authored-by: Mihailo Timotic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup to #50606, to address remaining issues in fixed-point analyzer and parser. This PR does the following:
SparkConnectandDataframeAPIDataframeAPIWhy are the changes needed?
To address current issue with
UnresolvedOrdinalDoes this PR introduce any user-facing change?
No
How was this patch tested?
Added a new test suite and existing tests.
Was this patch authored or co-authored using generative AI tooling?
No