[SPARK-51827][SS][CONNECT] Support Spark Connect on transformWithState in PySpark #50704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hvanhovell @HyukjinKwon @jingz-db Please take a look, thanks! |
HyukjinKwon
approved these changes
Apr 27, 2025
Contributor
Author
|
Thanks! Merging to master. |
LuciferYang
reviewed
Apr 27, 2025
python/pyspark/sql/connect/group.py
Outdated
Contributor
There was a problem hiding this comment.
@HeartSaVioR Did some code changes perhaps fail to be submitted ? After the merge, both the testing and lint checks failed.
Member
|
Sorry I missed your comment @LuciferYang This is reverted via 4c9c41e due to CI failures |
Contributor
Author
|
Argh, sorry. CI made me fun of me. This did not seem to go and pick the result (or really just merge conflicts, don't quite remember). I'll make a forward fix. |
HeartSaVioR
force-pushed
the
WIP-transform-with-state-python-in-spark-connect
branch
from
5d1213f to
a091fcc
Compare
Contributor
Author
|
This is the fix I added on top of merged PR. I'll merge if the CI passes since it was approved without 2 lines of changes, and I could have just +1 to @LuciferYang and merged. |
LuciferYang
approved these changes
Apr 27, 2025
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
+1, LGTM (pending tests)
Contributor
Author
|
https://github.com/HeartSaVioR/spark/runs/41228780833 Just confirmed CI is green. |
Contributor
Author
|
Thanks! Merging to master (again). |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…e in PySpark ### What changes were proposed in this pull request? This PR proposes to support Spark Connect on transformWithState in PySpark. The code is mostly reused between Pandas version and Row version. We rely on PythonEvanType to determine the user facing type of API, hence no proto change. ### Why are the changes needed? The new API needs to be supported with Spark Connect. ### Does this PR introduce _any_ user-facing change? Yes, we will expose a new API to be available in Spark Connect. ### How was this patch tested? New test suites. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50704 from HeartSaVioR/WIP-transform-with-state-python-in-spark-connect. Authored-by: Jungtaek Lim <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…e in PySpark ### What changes were proposed in this pull request? This PR proposes to support Spark Connect on transformWithState in PySpark. The code is mostly reused between Pandas version and Row version. We rely on PythonEvanType to determine the user facing type of API, hence no proto change. ### Why are the changes needed? The new API needs to be supported with Spark Connect. ### Does this PR introduce _any_ user-facing change? Yes, we will expose a new API to be available in Spark Connect. ### How was this patch tested? New test suites. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50704 from HeartSaVioR/WIP-transform-with-state-python-in-spark-connect. Authored-by: Jungtaek Lim <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to support Spark Connect on transformWithState in PySpark. The code is mostly reused between Pandas version and Row version.
We rely on PythonEvanType to determine the user facing type of API, hence no proto change.
Why are the changes needed?
The new API needs to be supported with Spark Connect.
Does this PR introduce any user-facing change?
Yes, we will expose a new API to be available in Spark Connect.
How was this patch tested?
New test suites.
Was this patch authored or co-authored using generative AI tooling?
No.