[SPARK-51898][PYTHON][CONNECT][TESTS][FOLLOW-UP] Fix inconsistent exception #50708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Apr 25, 2025
| assert isinstance(checkpointed._plan, plan.CachedRemoteRelation) | ||
| return checkpointed | ||
|
|
||
| if not is_remote_only(): |
Member
There was a problem hiding this comment.
This is actually intended, e.g., for autocompletetion
Member
There was a problem hiding this comment.
There are other cases in session.py as well.
Contributor
Author
There was a problem hiding this comment.
so we should just skip the test? or remove here and always throw PySparkAttributeError?
HyukjinKwon
approved these changes
Apr 27, 2025
Member
|
Merged to master. |
yhuang-db
pushed a commit
to yhuang-db/spark
that referenced
this pull request
Jun 9, 2025
…eption ### What changes were proposed in this pull request? apache#50693 enabled `SparkConnectErrorTests` in connect-only mode `toJSON` and `rdd` throw `PySparkNotImplementedError` in connect model, but `PySparkAttributeError` in connect-only model ### Why are the changes needed? to fix https://github.com/apache/spark/actions/runs/14649632571/job/41112060443 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? will be tested in daily builder ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#50708 from zhengruifeng/follow_up_connect_error. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#50693 enabled
SparkConnectErrorTestsin connect-only modetoJSONandrddthrowPySparkNotImplementedErrorin connect model, butPySparkAttributeErrorin connect-only modelWhy are the changes needed?
to fix https://github.com/apache/spark/actions/runs/14649632571/job/41112060443
Does this PR introduce any user-facing change?
no
How was this patch tested?
will be tested in daily builder
Was this patch authored or co-authored using generative AI tooling?
no