Skip to content

[SPARK-6475][SQL] recognize array types when infer data types from JavaBeans #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mengxr wants to merge 2 commits into from
Closed

[SPARK-6475][SQL] recognize array types when infer data types from JavaBeans #5146

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f2df5e
recognize array types when infer data types from JavaBeans
mengxr Mar 23, 2015
51e87e5
validate schemas
mengxr Mar 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
validate schemas
  • Loading branch information
@mengxr
mengxr committed Mar 24, 2015
commit 51e87e5caf6ea3b0af080673b82817b76534cc2d
8 changes: 8 additions & 0 deletions sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
import org.apache.spark.sql.*;
import org.apache.spark.sql.test.TestSQLContext;
import org.apache.spark.sql.test.TestSQLContext$;
import org.apache.spark.sql.types.*;

import static org.apache.spark.sql.functions.*;

public class JavaDataFrameSuite {
Expand Down Expand Up @@ -117,6 +119,12 @@ public void testCreateDataFrameFromJavaBeans() {
Bean bean = new Bean();
JavaRDD<Bean> rdd = jsc.parallelize(Arrays.asList(bean));
DataFrame df = context.createDataFrame(rdd, Bean.class);
StructType schema = df.schema();
Assert.assertEquals(new StructField("a", DoubleType$.MODULE$, false, Metadata.empty()),
schema.apply("a"));
Assert.assertEquals(
new StructField("b", new ArrayType(IntegerType$.MODULE$, true), true, Metadata.empty()),
schema.apply("b"));
Row first = df.select("a", "b").first();
Assert.assertEquals(bean.getA(), first.getDouble(0), 0.0);
Assert.assertArrayEquals(bean.getB(), first.<Integer[]>getAs(1));
Copy link
Contributor

@liancheng liancheng Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to add assertions for schema field data types.

Expand Down