Skip to content

[SPARK-53077][CORE][TESTS] Add an env to control the execution of the SparkBloomFilterSuite #51806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 4 commits into from
Closed

[SPARK-53077][CORE][TESTS] Add an env to control the execution of the SparkBloomFilterSuite #51806

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30fe595
init
LuciferYang Aug 4, 2025
40c123e
address commments
LuciferYang Aug 4, 2025
6307c8f
fix format
LuciferYang Aug 4, 2025
c54984a
format
LuciferYang Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build_java21.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ jobs:
"PYTHON_TO_TEST": "python3.11",
"SKIP_MIMA": "true",
"SKIP_UNIDOC": "true",
"DEDICATED_JVM_SBT_TESTS": "org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV1Suite,org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV2Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV1Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV2Suite"
"DEDICATED_JVM_SBT_TESTS": "org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV1Suite,org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormatV2Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV1Suite,org.apache.spark.sql.execution.datasources.orc.OrcSourceV2Suite",
"SPARK_TEST_SPARK_BF_SUITE_ENABLED": "true"
Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove this? Since this is a sketch module, I guess build_non_ansi.yml is enough because it's irrelevant to ANSI/non-ANSI.

}
jobs: >-
{
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build_non_ansi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
"PYSPARK_IMAGE_TO_TEST": "python-311",
"PYTHON_TO_TEST": "python3.11",
"SPARK_ANSI_SQL_MODE": "false",
"SPARK_TEST_SPARK_BF_SUITE_ENABLED": "true"
}
jobs: >-
{
Expand Down
3 changes: 2 additions & 1 deletion common/sketch/src/test/java/org/apache/spark/util/sketch/SparkBloomFilterSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.spark.util.sketch;

import org.junit.jupiter.api.*;
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
Expand All @@ -33,7 +34,7 @@
import java.util.stream.LongStream;
import java.util.stream.Stream;

@Disabled("TODO(SPARK-53077): Re-enable with a resonable test time.")
@EnabledIfEnvironmentVariable(named = "SPARK_TEST_SPARK_BF_SUITE_ENABLED", matches = "true")
Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this can be a role model for this kind of environment variable group, can we have a rule?

For example, if we have a rule SPARK_TEST_${CLASSNAME}_ENABLED, this should be SPARK_TEST_SPARK_BLOOM_FILTER_SUITE_ENABLED.

Although BF is reasonable, it looks like not a rule-based name from the suite name.

public class SparkBloomFilterSuite {

// the implemented fpp limit is only approximating the hard boundary,
Expand Down