[SPARK-53291][SQL] Fix nullability for value column #52043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-db
reviewed
Aug 15, 2025
| Seq( | ||
| StructField(VariantValueFieldName, BinaryType, nullable = true) |
There was a problem hiding this comment.
Is the PR description correct? It says:
currently always set the
valuecolumn to non-nullable
But, it looks like we always set it to nullable?
There was a problem hiding this comment.
Oops, yes, I've updated the PR description.
cloud-fan
approved these changes
Aug 16, 2025
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 16, 2025
### What changes were proposed in this pull request? For shredded Variant, we currently always set the `value` column to be nullable. But when there is no corresponding `typed_value`, and the value doesn't represent an object field (where null implies missing from the object), the `value` is never null, and we can set the column to be required. ### Why are the changes needed? This shouldn't affect results as read by Spark, but it may cause the parquet file to be marginally larger, and the [spec](https://github.com/apache/parquet-format/blob/master/VariantShredding.md) wording indicates that `value` must be required in these situations, so a strict reader could reject the schema as it's currently being produced. ### Does this PR introduce _any_ user-facing change? Variant parquet file schema may change slightly. ### How was this patch tested? Unit test extended to cover this case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52043 from cashmand/fix_nullability. Authored-by: cashmand <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit fd77ec6) Signed-off-by: Wenchen Fan <[email protected]>
mzhang
pushed a commit
to mzhang/spark
that referenced
this pull request
Aug 21, 2025
### What changes were proposed in this pull request? For shredded Variant, we currently always set the `value` column to be nullable. But when there is no corresponding `typed_value`, and the value doesn't represent an object field (where null implies missing from the object), the `value` is never null, and we can set the column to be required. ### Why are the changes needed? This shouldn't affect results as read by Spark, but it may cause the parquet file to be marginally larger, and the [spec](https://github.com/apache/parquet-format/blob/master/VariantShredding.md) wording indicates that `value` must be required in these situations, so a strict reader could reject the schema as it's currently being produced. ### Does this PR introduce _any_ user-facing change? Variant parquet file schema may change slightly. ### How was this patch tested? Unit test extended to cover this case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52043 from cashmand/fix_nullability. Authored-by: cashmand <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For shredded Variant, we currently always set the
valuecolumn to be nullable. But when there is no correspondingtyped_value, and the value doesn't represent an object field (where null implies missing from the object), thevalueis never null, and we can set the column to be required.Why are the changes needed?
This shouldn't affect results as read by Spark, but it may cause the parquet file to be marginally larger, and the spec wording indicates that
valuemust be required in these situations, so a strict reader could reject the schema as it's currently being produced.Does this PR introduce any user-facing change?
Variant parquet file schema may change slightly.
How was this patch tested?
Unit test extended to cover this case.
Was this patch authored or co-authored using generative AI tooling?
No.