Skip to content

[SPARK-53394][CORE] UninterruptibleLock.isInterruptible should avoid duplicated interrupt #52139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ngone51 wants to merge 5 commits into from
Closed

[SPARK-53394][CORE] UninterruptibleLock.isInterruptible should avoid duplicated interrupt #52139

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0c167f
fix
Ngone51 Aug 27, 2025
20e6bfb
comment
Ngone51 Aug 27, 2025
fbeb5aa
address comment
Ngone51 Aug 27, 2025
48dbe43
update comment
Ngone51 Aug 28, 2025
6d473d2
address comment
Ngone51 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ private[spark] class UninterruptibleThread(
* is true) and no concurrent [[interrupt()]] call, otherwise false
*/
def isInterruptible: Boolean = synchronized {
shouldInterruptThread = uninterruptible
// SPARK-53394: We should not interrupt the thread when it is already interrupted.
// Otherwise, the state of `shouldInterruptThread` becomes inconsistent between
// `isInterruptible()` and `isInterruptPending()`, leading to `UninterruptibleThread`
// be interruptible under `runUninterruptibly`.
shouldInterruptThread = uninterruptible || UninterruptibleThread.this.isInterrupted
// as we are releasing uninterruptibleLock before calling super.interrupt() there is a
// possibility that runUninterruptibly() would be called after lock is released but before
// super.interrupt() is called. In this case to prevent runUninterruptibly() from being
Expand Down