-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-49386][CORE][SQL][FOLLOWUP] More accurate memory tracking for memory based spill threshold #52190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49386][CORE][SQL][FOLLOWUP] More accurate memory tracking for memory based spill threshold #52190
Changes from 1 commit
b586774
350754b
4920958
16fc9e8
8023fd3
32a744d
cc33b04
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,14 +36,14 @@ import org.apache.spark.util.collection.unsafe.sort.{UnsafeExternalSorter, Unsaf | |
| * An append-only array for [[UnsafeRow]]s that strictly keeps content in an in-memory array | ||
| * until [[numRowsInMemoryBufferThreshold]] or [[sizeInBytesInMemoryBufferThreshold]] is reached | ||
| * post which it will switch to a mode (backed by [[UnsafeExternalSorter]]) which would flush to | ||
| * disk after [[numRowsSpillThreshold]] is met (or before if there is excessive memory consumption). | ||
| * Setting these threshold involves following trade-offs: | ||
| * disk after [[numRowsSpillThreshold]] or [[sizeInBytesSpillThreshold]] is met (or before if there | ||
| * is excessive memory consumption). Setting these threshold involves following trade-offs: | ||
| * | ||
| * - If [[numRowsInMemoryBufferThreshold]] and [[sizeInBytesInMemoryBufferThreshold]] are too high, | ||
| * the in-memory array may occupy more memory than is available, resulting in OOM. | ||
| * - If [[numRowsSpillThreshold]] is too low, data will be spilled frequently and lead to | ||
| * excessive disk writes. This may lead to a performance regression compared to the normal case | ||
| * of using an [[ArrayBuffer]] or [[Array]]. | ||
| * - If [[numRowsSpillThreshold]] or [[sizeInBytesSpillThreshold]] is too low, data will be spilled | ||
| * frequently and lead to excessive disk writes. This may lead to a performance regression compared | ||
| * to the normal case of using an [[ArrayBuffer]] or [[Array]]. | ||
| */ | ||
| class ExternalAppendOnlyUnsafeRowArray( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does The previous PR added parameters in
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. other data structures (
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've updated the classdoc |
||
| taskMemoryManager: TaskMemoryManager, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.