[SPARK-53577][DOCS] Fix Scaladoc source links for java sources #52338
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-toth
approved these changes
Sep 15, 2025
HyukjinKwon
approved these changes
Sep 15, 2025
|
Merged to master. |
yaooqinn
added a commit
that referenced
this pull request
Sep 16, 2025
### What changes were proposed in this pull request?
Replace `€{FILE_PATH}.scala` with `€{FILE_PATH_EXT}` as the placeholder for generating Scaladoc source links
### Why are the changes needed?
Fix 404 for cases like https://spark.apache.org/docs/latest/api/scala/org/apache/spark/launcher/JavaModuleOptions.html
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Build Scala doc locally to verify
### Was this patch authored or co-authored using generative AI tooling?
no
Closes #52338 from yaooqinn/SPARK-53577.
Authored-by: Kent Yao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 10b27f3)
Signed-off-by: Kent Yao <[email protected]>
yaooqinn
added a commit
that referenced
this pull request
Sep 16, 2025
### What changes were proposed in this pull request?
Replace `€{FILE_PATH}.scala` with `€{FILE_PATH_EXT}` as the placeholder for generating Scaladoc source links
### Why are the changes needed?
Fix 404 for cases like https://spark.apache.org/docs/latest/api/scala/org/apache/spark/launcher/JavaModuleOptions.html
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Build Scala doc locally to verify
### Was this patch authored or co-authored using generative AI tooling?
no
Closes #52338 from yaooqinn/SPARK-53577.
Authored-by: Kent Yao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 10b27f3)
Signed-off-by: Kent Yao <[email protected]>
|
Thank you @dongjoon-hyun, @peter-toth, and @HyukjinKwon. FYI, I also picked this to branch 4.0 and 3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace
€{FILE_PATH}.scalawith€{FILE_PATH_EXT}as the placeholder for generating Scaladoc source linksWhy are the changes needed?
Fix 404 for cases like https://spark.apache.org/docs/latest/api/scala/org/apache/spark/launcher/JavaModuleOptions.html
Does this PR introduce any user-facing change?
no
How was this patch tested?
Build Scala doc locally to verify
Was this patch authored or co-authored using generative AI tooling?
no