Skip to content

[SPARK-7007][core] Add a metric source for ExecutorAllocationManager #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerryshao wants to merge 4 commits into from
Closed

[SPARK-7007][core] Add a metric source for ExecutorAllocationManager #5589

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c3540f
Add a metric source for ExecutorAllocationManager
jerryshao Apr 20, 2015
d237ba5
Address the comments
jerryshao Apr 29, 2015
c501a2c
Address the comments
jerryshao Apr 30, 2015
104d155
rebase and address the comments
jerryshao May 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address the comments
  • Loading branch information
@jerryshao
jerryshao committed May 2, 2015
commit d237ba587b01d6fe297ba6702369e17cc58e2f78
41 changes: 22 additions & 19 deletions core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,25 +147,8 @@ private[spark] class ExecutorAllocationManager(
private val executor =
ThreadUtils.newDaemonSingleThreadScheduledExecutor("spark-dynamic-executor-allocation")

// Metric source for ExecutorAllocationManager to expose the its internal executor allocation
// status to MetricsSystem.
private[spark] val executorAllocationManagerSource = new Source {
val sourceName = "ExecutorAllocationManager"
val metricRegistry = new MetricRegistry()

private def registerGauge[T](name: String, value: => T, defaultValue: T): Unit = {
metricRegistry.register(MetricRegistry.name("executors", name), new Gauge[T] {
override def getValue: T = synchronized { Option(value).getOrElse(defaultValue) }
})
}

registerGauge("numberExecutorsToAdd", numExecutorsToAdd, 0)
registerGauge("numberExecutorsPending", numExecutorsPending, 0)
registerGauge("numberExecutorsPendingToRemove", executorsPendingToRemove.size, 0)
registerGauge("numberAllExecutors", executorIds.size, 0)
registerGauge("numberTargetExecutors", targetNumExecutors(), 0)
registerGauge("numberMaxNeededExecutors", maxNumExecutorsNeeded(), 0)
}
// Metric source for ExecutorAllocationManager to expose internal status to MetricsSystem.
private[spark] val executorAllocationManagerSource = new ExecutorAllocationManagerSource

/**
* Verify that the settings specified through the config are valid.
Expand Down Expand Up @@ -602,6 +585,26 @@ private[spark] class ExecutorAllocationManager(
}
}

// Metric source for ExecutorAllocationManager to expose the its internal executor allocation
Copy link
Contributor

@sryza sryza Apr 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "the" and "its" are redundant. Also, this should be a block-style comment.

// status to MetricsSystem.
// Note: these metrics may not be stable across Spark version.
private[spark] class ExecutorAllocationManagerSource extends Source {
val sourceName = "ExecutorAllocationManager"
val metricRegistry = new MetricRegistry()

private def registerGauge[T](name: String, value: => T, defaultValue: T): Unit = {
metricRegistry.register(MetricRegistry.name("executors", name), new Gauge[T] {
override def getValue: T = synchronized { Option(value).getOrElse(defaultValue) }
})
}

registerGauge("numberExecutorsToAdd", numExecutorsToAdd, 0)
registerGauge("numberExecutorsPending", numExecutorsPending, 0)
registerGauge("numberExecutorsPendingToRemove", executorsPendingToRemove.size, 0)
registerGauge("numberAllExecutors", executorIds.size, 0)
registerGauge("numberTargetExecutors", targetNumExecutors(), 0)
registerGauge("numberMaxNeededExecutors", maxNumExecutorsNeeded(), 0)
}
}

private object ExecutorAllocationManager {
Expand Down