Skip to content

[HOTFIX][SQL] Fix broken cached test #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 1 commit into from
Closed

[HOTFIX][SQL] Fix broken cached test #5640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,19 +300,26 @@ class CachedTableSuite extends QueryTest {
}

test("Clear accumulators when uncacheTable to prevent memory leaking") {
val accsSize = Accumulators.originals.size

sql("SELECT key FROM testData LIMIT 10").registerTempTable("t1")
sql("SELECT key FROM testData LIMIT 5").registerTempTable("t2")
cacheTable("t1")
cacheTable("t2")

Accumulators.synchronized {
val accsSize = Accumulators.originals.size
cacheTable("t1")
cacheTable("t2")
assert((accsSize + 2) == Accumulators.originals.size)
}

sql("SELECT * FROM t1").count()
sql("SELECT * FROM t2").count()
sql("SELECT * FROM t1").count()
sql("SELECT * FROM t2").count()
uncacheTable("t1")
uncacheTable("t2")

assert(accsSize >= Accumulators.originals.size)
Accumulators.synchronized {
val accsSize = Accumulators.originals.size
uncacheTable("t1")
uncacheTable("t2")
assert((accsSize - 2) == Accumulators.originals.size)
}
}
}