Skip to content

[SPARK-7066][MLlib] VectorAssembler should use NumericType not NativeType. #5642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rxin wants to merge 2 commits into from
Closed

[SPARK-7066][MLlib] VectorAssembler should use NumericType not NativeType. #5642

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cbb205
[SPARK-7066][MLlib] VectorAssembler should use NumericType and String…
rxin Apr 23, 2015
e23af5b
Remove StringType
rxin Apr 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove StringType
  • Loading branch information
@rxin
rxin committed Apr 23, 2015
commit e23af5b22f2cfbe36117d62adf05d40e19b3584c
4 changes: 2 additions & 2 deletions mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class VectorAssembler extends Transformer with HasInputCols with HasOutputCol {
schema(c).dataType match {
case DoubleType => UnresolvedAttribute(c)
case t if t.isInstanceOf[VectorUDT] => UnresolvedAttribute(c)
case _: NumericType | StringType =>
case _: NumericType =>
Alias(Cast(UnresolvedAttribute(c), DoubleType), s"${c}_double_$uid")()
}
}
Expand All @@ -68,7 +68,7 @@ class VectorAssembler extends Transformer with HasInputCols with HasOutputCol {
val outputColName = map(outputCol)
val inputDataTypes = inputColNames.map(name => schema(name).dataType)
inputDataTypes.foreach {
case _: NumericType | StringType =>
case _: NumericType =>
case t if t.isInstanceOf[VectorUDT] =>
case other =>
throw new IllegalArgumentException(s"Data type $other is not supported.")
Expand Down