SPARK-7103: Fix crash with SparkContext.union when RDD has no partitioner #5679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as no partitioner
Member
There was a problem hiding this comment.
Yeah I like this. I suppose that the pre-existing condition already caught the empty RDD case, which PartitionerAwareUnionRDD will reject. Although symmetry between this check and the following one would be nice I don't think it's important. This looks correct since clearly PartitionerAwareUnionRDD intends to operate only on RDDs with partitioners.
Contributor
|
Jenkins, test his please. This LGTM |
Member
|
ok to test |
|
Test build #705 has finished for PR 5679 at commit
|
Member
|
Jenkins, retest this please |
|
Test build #714 has started for PR 5679 at commit |
Member
|
Jenkins has trouble posting this back, but it failed unit tests, however this seems to be for unrelated reasons. Let me try again. |
|
Test build #716 has finished for PR 5679 at commit
|
|
Can one of the admins verify this patch? |
asfgit
pushed a commit
that referenced
this pull request
Apr 27, 2015
…ioner Added a check to the SparkContext.union method to check that a partitioner is defined on all RDDs when instantiating a PartitionerAwareUnionRDD. Author: Steven She <[email protected]> Closes #5679 from stevencanopy/SPARK-7103 and squashes the following commits: 5a3d846 [Steven She] SPARK-7103: Fix crash with SparkContext.union when at least one RDD has no partitioner (cherry picked from commit b9de9e0) Signed-off-by: Sean Owen <[email protected]>
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
May 14, 2015
…ioner Added a check to the SparkContext.union method to check that a partitioner is defined on all RDDs when instantiating a PartitionerAwareUnionRDD. Author: Steven She <[email protected]> Closes apache#5679 from stevencanopy/SPARK-7103 and squashes the following commits: 5a3d846 [Steven She] SPARK-7103: Fix crash with SparkContext.union when at least one RDD has no partitioner
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
…ioner Added a check to the SparkContext.union method to check that a partitioner is defined on all RDDs when instantiating a PartitionerAwareUnionRDD. Author: Steven She <[email protected]> Closes apache#5679 from stevencanopy/SPARK-7103 and squashes the following commits: 5a3d846 [Steven She] SPARK-7103: Fix crash with SparkContext.union when at least one RDD has no partitioner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to the SparkContext.union method to check that a partitioner is defined on all RDDs when instantiating a PartitionerAwareUnionRDD.