Skip to content

[minor] [core] Warn users who try to cache RDDs with dynamic allocation on. #5751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanzin wants to merge 2 commits into from
Closed

[minor] [core] Warn users who try to cache RDDs with dynamic allocation on. #5751

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9efb9da
[minor] [core] Warn users who try to cache RDDs with dynamic allocati…
Apr 28, 2015
554cc07
Change message.
Apr 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[minor] [core] Warn users who try to cache RDDs with dynamic allocati… 
…on on.
  • Loading branch information
Marcelo Vanzin committed Apr 28, 2015
commit 9efb9daea3fa6ac438fcd919da88946fce8671f9
5 changes: 5 additions & 0 deletions core/src/main/scala/org/apache/spark/SparkContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,6 +1387,11 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
* Register an RDD to be persisted in memory and/or disk storage
*/
private[spark] def persistRDD(rdd: RDD[_]) {
_executorAllocationManager.foreach { _ =>
logWarning(
s"Dynamic allocation currently does not support cached RDDs. Cached data for RDD " +
s"${rdd.id} will be deallocated when executors are removed.")
Copy link
Contributor

@sryza sryza Apr 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we say "lost" instead of "deallocated"? Deallocate has a connotation to me of purposely returned to a pool, where as this is more a situation of unpurposely returned to nowhere accessible.

Copy link
Contributor Author

@vanzin vanzin Apr 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about lost but thought it would be too strong, since the data can be recomputed. But sure, it sounds more correct than "deallocated".

}
persistentRdds(rdd.id) = rdd
}

Expand Down