Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Apr 29, 2015

Add support for changing the log level at run time through the SparkContext. Based on an earlier PR, #2433 includes CR feedback from @pwendel & @davies

…ontext. Based on an earlier PR, apache#2433 includes CR feedback from @pwendel & @davies
@SparkQA
Copy link

SparkQA commented Apr 29, 2015

Test build #31340 has finished for PR 5791 at commit d9d03f3.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final class Word2Vec extends Estimator[Word2VecModel] with Word2VecBase
    • trait HasStepSize extends Params
  • This patch does not change any dependencies.

@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31352 has finished for PR 5791 at commit fac14a0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final class Word2Vec extends Estimator[Word2VecModel] with Word2VecBase
    • trait HasStepSize extends Params
  • This patch does not change any dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Holden - can you have it be that if we see an invalid level we throw an exception? Otherwise it could be confusing if a user simply has a typo or something. Something like:

val validLevels = Seq("ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF", "TRACE", "WARN")
if (!validLevels.contains(logLevel.toUpperCase) {
  throw new InvalidArgumentException(
    s"Supplied level $logLevel did not match one of: ${validLevels.mkString(',')}")
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this instead of the default to debug behavior that is currently present?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I'm suggesting that before you pass anything to log4j we make sure it's one of the valid logging levels. Therefore, the default behavior of log4j's toLevel will be irrelevant.

@pwendell
Copy link
Contributor

pwendell commented May 1, 2015

Looks great, but left one small comment.

@SparkQA
Copy link

SparkQA commented May 1, 2015

Test build #31596 has finished for PR 5791 at commit 338d7bf.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor

pwendell commented May 1, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented May 1, 2015

Test build #31606 has finished for PR 5791 at commit 338d7bf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 2, 2015

Test build #31628 has finished for PR 5791 at commit 3bf3be9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in ae98eec May 2, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
Add support for changing the log level at run time through the SparkContext. Based on an earlier PR, apache#2433 includes CR feedback from pwendel & davies

Author: Holden Karau <[email protected]>

Closes apache#5791 from holdenk/SPARK-3444-provide-an-easy-way-to-change-log-level-r2 and squashes the following commits:

3bf3be9 [Holden Karau] fix exception
42ba873 [Holden Karau] fix exception
9117244 [Holden Karau] Only allow valid log levels, throw exception if invalid log level.
338d7bf [Holden Karau] rename setLoggingLevel to setLogLevel
fac14a0 [Holden Karau] Fix style errors
d9d03f3 [Holden Karau] Add support for changing the log level at run time through the SparkContext. Based on an earlier PR, apache#2433 includes CR feedback from @pwendel & @davies
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Add support for changing the log level at run time through the SparkContext. Based on an earlier PR, apache#2433 includes CR feedback from pwendel & davies

Author: Holden Karau <[email protected]>

Closes apache#5791 from holdenk/SPARK-3444-provide-an-easy-way-to-change-log-level-r2 and squashes the following commits:

3bf3be9 [Holden Karau] fix exception
42ba873 [Holden Karau] fix exception
9117244 [Holden Karau] Only allow valid log levels, throw exception if invalid log level.
338d7bf [Holden Karau] rename setLoggingLevel to setLogLevel
fac14a0 [Holden Karau] Fix style errors
d9d03f3 [Holden Karau] Add support for changing the log level at run time through the SparkContext. Based on an earlier PR, apache#2433 includes CR feedback from @pwendel & @davies
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Add support for changing the log level at run time through the SparkContext. Based on an earlier PR, apache#2433 includes CR feedback from pwendel & davies

Author: Holden Karau <[email protected]>

Closes apache#5791 from holdenk/SPARK-3444-provide-an-easy-way-to-change-log-level-r2 and squashes the following commits:

3bf3be9 [Holden Karau] fix exception
42ba873 [Holden Karau] fix exception
9117244 [Holden Karau] Only allow valid log levels, throw exception if invalid log level.
338d7bf [Holden Karau] rename setLoggingLevel to setLogLevel
fac14a0 [Holden Karau] Fix style errors
d9d03f3 [Holden Karau] Add support for changing the log level at run time through the SparkContext. Based on an earlier PR, apache#2433 includes CR feedback from @pwendel & @davies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants