Skip to content

[SPARK-7312][SQL] SPARK-6913 broke jdk6 build #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yhuai wants to merge 1 commit into from
Closed

[SPARK-7312][SQL] SPARK-6913 broke jdk6 build #5847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/jdbc/jdbc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

package org.apache.spark.sql

import java.sql.{Connection, Driver, DriverManager, DriverPropertyInfo, PreparedStatement}
import java.sql.{Connection, Driver, DriverManager, DriverPropertyInfo, PreparedStatement, SQLFeatureNotSupportedException}
import java.util.Properties

import scala.collection.mutable
Expand Down Expand Up @@ -195,7 +195,9 @@ package object jdbc {

override def getMinorVersion: Int = wrapped.getMinorVersion

override def getParentLogger: java.util.logging.Logger = wrapped.getParentLogger
def getParentLogger: java.util.logging.Logger =
Copy link
Member

@srowen srowen May 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks like the right thing to do according to the docs:
http://docs.oracle.com/javase/7/docs/api/java/sql/Driver.html#getParentLogger()

throw new SQLFeatureNotSupportedException(
s"${this.getClass().getName}.getParentLogger is not yet implemented.")

override def connect(url: String, info: Properties): Connection = wrapped.connect(url, info)

Expand Down