[SPARK-7319][SQL] Improve the output from DataFrame.show()

[kaka1992]

No description provided.

[marmbrus]

Please include a before and after example of the output and a description of what you changed (in the PR description).

[marmbrus]

Undo this change.

[kaka1992]

testData.select($"*").show(5)

Before:

key value
1   1    
2   2    
3   3    
4   4    
5   5 

After:

+---+-----+
|key|value|
|  1|    1|
|  2|    2|
|  3|    3|
|  4|    4|
|  5|    5|
+---+-----+

[rxin]

@kaka1992 Thanks a lot for being so helpful. I have two requests:

1. Can you add a line after the header, exactly like what I wrote in the JIRA ticket?
2. Can you read this coding style guide and clean up the code? https://github.com/databricks/scala-style-guide In general, it would be great to have the style match exactly rest of the code. Thanks.

[rxin]

it would be great to create unit test for showString in DataFrameSuite.

[rxin]

you can use multi line string in Scala, especially with stripMargin.

http://alvinalexander.com/scala/scala-multiline-strings-heredoc-syntax

[rxin]

This is looking pretty good now. I think you would need to fix some Python tests as well, as they were expecting the output from show.

[kaka1992]

@rxin Please test this PR.

[rxin]

it's pretty awkward to have this at the end. I'd just create a variable for the expected string so we don't have so much whitespace.

[rxin]

Jenkins, test this please.

[rxin]

Jenkins, retest this please.

[SparkQA]

Test build #31728 has finished for PR 5865 at commit a1338f6.

• This patch fails to build.
• This patch merges cleanly.
• This patch adds no public classes.

[kaka1992]

@rxin error: oro#oro;2.0.8!oro.jar origin location must be absolute. What's wrong with building?

[rxin]

Jenkins, retest this please.

[SparkQA]

Test build #31731 has finished for PR 5865 at commit a1338f6.

• This patch fails SparkR unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[kaka1992]

@rxin Fixed showDF test in R.

[rxin]

Jenkins, ok to test.

[shivaram]

SparkR changes look good

[SparkQA]

Test build #31764 has finished for PR 5865 at commit c79204b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • abstract class ShuffleHandle(val shuffleId: Int) extends Serializable
  • * class SomethingNotSerializable
  • logDebug(s" + cloning the object $obj of class $
  • class SaslEncryption
  • static class EncryptedMessage extends AbstractReferenceCounted implements FileRegion
  • class SaslRpcHandler extends RpcHandler
  • public class SaslServerBootstrap implements TransportServerBootstrap
  • public class SparkSaslClient implements SaslEncryptionBackend
  • public class SparkSaslServer implements SaslEncryptionBackend
  • public class ByteArrayWritableChannel implements WritableByteChannel

[rxin]

Thanks a lot for doing this. I'm merging this in master.