Skip to content

[SPARK-5893][ML] Add bucketizer #5980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yinxusen wants to merge 13 commits into from
Closed

[SPARK-5893][ML] Add bucketizer #5980

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5fe190e
add bucketizer
yinxusen May 7, 2015
4024cf1
add test suite
yinxusen May 7, 2015
998bc87
check buckets
yinxusen May 7, 2015
11fb00a
change it into an Estimator
yinxusen May 7, 2015
2466322
refactor Bucketizer
yinxusen May 7, 2015
fb30d79
fix and test binary search
yinxusen May 7, 2015
ac77859
fix style error
yinxusen May 8, 2015
3a16cc2
refine comments and names
yinxusen May 8, 2015
c3cc770
add more unit test for binary search
yinxusen May 8, 2015
eacfcfa
change ML attribute from splits into buckets
yinxusen May 8, 2015
34f124a
Removed lowerInclusive, upperInclusive params from Bucketizer, and us…
jkbradley May 11, 2015
1ca973a
one more bucketizer test
jkbradley May 11, 2015
dc8c843
Merge pull request #4 from jkbradley/yinxusen-SPARK-5893
yinxusen May 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix style error
  • Loading branch information
@yinxusen
yinxusen committed May 8, 2015
commit ac778591ad55845912dc6608d8de5e2935c95f73
3 changes: 2 additions & 1 deletion mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,10 @@ object Bucketizer {
feature: Double,
lowerInclusive: Boolean,
upperInclusive: Boolean): Double = {
if ((feature < splits.head && !lowerInclusive) || (feature > splits.last && !upperInclusive))
if ((feature < splits.head && !lowerInclusive) || (feature > splits.last && !upperInclusive)) {
throw new Exception(s"Feature $feature out of bound, check your features or loose the" +
Copy link
Member

@jkbradley jkbradley May 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a RuntimeException

Also, typo: "loose" --> "loosen"

s" lower/upper bound constraint.")
}
var left = 0
var right = splits.length - 2
while (left <= right) {
Expand Down