Skip to content

SPARK-7137 [ML] : Update SchemaUtils checkInputColumn to print more info if needed #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rekhajoshm wants to merge 5 commits into from
Closed

SPARK-7137 [ML] : Update SchemaUtils checkInputColumn to print more info if needed #5992

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3677c9
Merge pull request #1 from apache/master
rekhajoshm May 5, 2015
8993c0e
SPARK-7137: Add checkInputColumn back to Params and print more info
rekhajoshm May 7, 2015
acf3e17
update checkInputColumn to print more info if needed
rekhajoshm Jul 1, 2015
33ddd2e
update checkInputColumn to print more info if needed
rekhajoshm Jul 2, 2015
8c42b57
update checkInputColumn to print more info if needed
rekhajoshm Jul 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update checkInputColumn to print more info if needed
  • Loading branch information
@rekhajoshm
rekhajoshm committed Jul 2, 2015
commit 33ddd2e3fa56212f48c748dee7751eeafe6763f0
7 changes: 5 additions & 2 deletions mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,14 @@ object SchemaUtils {
* @param colName column name
* @param dataType required column data type
*/
def checkColumnType(schema: StructType, colName: String, dataType: DataType,
def checkColumnType(schema: StructType,
colName: String,
Copy link
Contributor

@mengxr mengxr Jul 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the Spark code style guide and use 4-space indentation for arguments: https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide

dataType: DataType,
msg: String = ""): Unit = {
val actualDataType = schema(colName).dataType
val message = if (msg != null && msg.trim.length > 0) " " + msg else ""
require(actualDataType.equals(dataType),
s"Column $colName must be of type $dataType but was actually $actualDataType.$msg")
s"Column $colName must be of type $dataType but was actually $actualDataType.$message")
}

/**
Expand Down