Skip to content

[SPARK-6092] [MLLIB] Add RankingMetrics in PySpark/MLlib #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yanboliang wants to merge 2 commits into from
Closed

[SPARK-6092] [MLLIB] Add RankingMetrics in PySpark/MLlib #6044

yanboliang wants to merge 2 commits into from

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented May 10, 2015

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented May 10, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 10, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 10, 2015

Test build #32349 has started for PR 6044 at commit 33f649c.

@SparkQA
Copy link

SparkQA commented May 10, 2015

Test build #32349 has finished for PR 6044 at commit 33f649c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RankingMetrics(JavaModelWrapper):

@AmplabJenkins
Copy link

AmplabJenkins commented May 10, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 10, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32349/
Test FAILed.

@yanboliang
Copy link
Contributor Author

yanboliang commented May 11, 2015

Jenkins, retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32364 has started for PR 6044 at commit 33f649c.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32364 has finished for PR 6044 at commit 33f649c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RankingMetrics(JavaModelWrapper):

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32364/
Test FAILed.

@mengxr
Copy link
Contributor

mengxr commented May 11, 2015

test this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32372 has started for PR 6044 at commit 33f649c.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32372 has finished for PR 6044 at commit 33f649c.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RankingMetrics(JavaModelWrapper):

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32372/
Test FAILed.

@yanboliang
Copy link
Contributor Author

yanboliang commented May 11, 2015

It looks like py4j can not recognize [T: ClassTag] for RankingMetrics.
If I removed [T: ClassTag] and specify the type (for example: Int) of RankingMetrics, py4j can find the constructor. Maybe I need to wrapper the RankingMetrics in scala, looking forward your comments. @mengxr

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32385 has started for PR 6044 at commit 726a9b1.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32385 has finished for PR 6044 at commit 726a9b1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RankingMetrics(JavaModelWrapper):

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32385/
Test FAILed.

@yanboliang
Copy link
Contributor Author

yanboliang commented May 11, 2015

Jenkins, retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32390 has started for PR 6044 at commit 726a9b1.

@SparkQA
Copy link

SparkQA commented May 11, 2015

Test build #32390 has finished for PR 6044 at commit 726a9b1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RankingMetrics(JavaModelWrapper):

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32390/
Test PASSed.

@asfgit asfgit closed this in 042dda3 May 11, 2015
asfgit pushed a commit that referenced this pull request May 11, 2015
@yanboliang @mengxr
[SPARK-6092] [MLLIB] Add RankingMetrics in PySpark/MLlib
017f9fa 
Author: Yanbo Liang <[email protected]>

Closes #6044 from yanboliang/spark-6092 and squashes the following commits:

726a9b1 [Yanbo Liang] add newRankingMetrics
33f649c [Yanbo Liang] Add RankingMetrics in PySpark/MLlib

(cherry picked from commit 042dda3)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented May 11, 2015

The current solution looks good to me. Merged into master and branch-1.4. We might have problems with Java compatibility with class tags (SPARK-7528). We can figure out a solution later.

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@yanboliang @jeanlyn
[SPARK-6092] [MLLIB] Add RankingMetrics in PySpark/MLlib
ae9e147 
Author: Yanbo Liang <[email protected]>

Closes apache#6044 from yanboliang/spark-6092 and squashes the following commits:

726a9b1 [Yanbo Liang] add newRankingMetrics
33f649c [Yanbo Liang] Add RankingMetrics in PySpark/MLlib
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@yanboliang @jeanlyn
[SPARK-6092] [MLLIB] Add RankingMetrics in PySpark/MLlib
7e9c32e 
Author: Yanbo Liang <[email protected]>

Closes apache#6044 from yanboliang/spark-6092 and squashes the following commits:

726a9b1 [Yanbo Liang] add newRankingMetrics
33f649c [Yanbo Liang] Add RankingMetrics in PySpark/MLlib
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@yanboliang @nemccarthy
[SPARK-6092] [MLLIB] Add RankingMetrics in PySpark/MLlib
6c10d25 
Author: Yanbo Liang <[email protected]>

Closes apache#6044 from yanboliang/spark-6092 and squashes the following commits:

726a9b1 [Yanbo Liang] add newRankingMetrics
33f649c [Yanbo Liang] Add RankingMetrics in PySpark/MLlib
@yanboliang yanboliang deleted the spark-6092 branch June 26, 2015 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanboliang @AmplabJenkins @SparkQA @mengxr