Skip to content

[SPARK-7687] [SQL] DataFrame.describe() should cast all aggregates to String #6218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 4 commits into from
Closed

[SPARK-7687] [SQL] DataFrame.describe() should cast all aggregates to String #6218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
307ecbf
Add failing regression test for SPARK-7687
JoshRosen May 17, 2015
f206580
Cast to double to fix SPARK-7687
JoshRosen May 17, 2015
2974bd5
Cast to string type instead
JoshRosen May 18, 2015
146b615
Fix R test.
JoshRosen May 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add failing regression test for SPARK-7687
  • Loading branch information
@JoshRosen
JoshRosen committed May 18, 2015
commit 307ecbf314b1a01a8f5051e5f9aa8b5985b93ac0
6 changes: 3 additions & 3 deletions python/pyspark/sql/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,11 +599,11 @@ def describe(self, *cols):
+-------+---+
|summary|age|
+-------+---+
| count| 2|
| count|2.0|
| mean|3.5|
| stddev|1.5|
| min| 2|
| max| 5|
| min|2.0|
| max|5.0|
+-------+---+
"""
jdf = self._jdf.describe(self._jseq(cols))
Expand Down
5 changes: 5 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,11 @@ class DataFrameSuite extends QueryTest {
val describeTwoCols = describeTestData.describe("age", "height")
assert(getSchemaAsSeq(describeTwoCols) === Seq("summary", "age", "height"))
checkAnswer(describeTwoCols, describeResult)
// All aggregate value should have been cast to double, including `count`
describeTwoCols.collect().foreach { row =>
assert(row.get(1).isInstanceOf[Double], "expected double but found " + row.get(1).getClass)
assert(row.get(2).isInstanceOf[Double], "expected double but found " + row.get(2).getClass)
}

val describeAllCols = describeTestData.describe()
assert(getSchemaAsSeq(describeAllCols) === Seq("summary", "age", "height"))
Expand Down