[SPARK-6740][SQL] Fix NOT operator precedence.

[smola]

NOT has lower precedence than comparison operations.

[chenghao-intel]

Instead of bind the rule booleanFactor with andExpression, a better place probably be expression rule. (https://github.com/smola/spark/blob/feature/operator-precedence/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala#L225)

[smola]

@chenghao-intel Not sure how. Adding the NOT clause in the expression rule would break precedence rules. Also, binding expression -> orExpression -> andExpression -> booleanFactor -> comparison is pretty much they way it is expressed in the grammars for standard SQL.

[chenghao-intel]

Oh, sorry, my bad, I just picked up some corner case, it works.

[marmbrus]

Sorry for the delay here. Mind bringing this up to date?

[smola]

@marmbrus Done.

[marmbrus]

ok to test

[SparkQA]

Test build #35151 has finished for PR 6326 at commit f9e9021.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[marmbrus]

Minor style issues:

/home/jenkins/workspace/SparkPullRequestBuilder/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala:221:40: No space before token =>
[error] (catalyst/compile:scalastyle) errors exist
[error] Total time: 8 s, completed Jun 18, 2015 12:51:02 PM
[error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala:221:40: No space before token =>
[error] (catalyst/compile:scalastyle) errors exist

[SparkQA]

Test build #35700 has finished for PR 6326 at commit 75b7c95.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #35701 has finished for PR 6326 at commit fbc1815.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • s"Using output committer class $
  • logInfo(s"Using user defined output committer class $
  • s"Using output committer class $

[AmplabJenkins]

Can one of the admins verify this patch?

[rxin]

@smola do you have time to fix the test failure so we can merge this for 1.5?

[marmbrus]

Thanks for working on this @smola. I propose we close this issue until you have time to fix the test failures.