Skip to content

[SPARK-7979] Enforce structural type checker. #6536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rxin wants to merge 3 commits into from
Closed

[SPARK-7979] Enforce structural type checker. #6536

rxin wants to merge 3 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented May 31, 2015

No description provided.

rxin
rxin reviewed May 31, 2015
View reviewed changes
examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala Outdated
Copy link
Contributor Author

@rxin rxin May 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mengxr @jkbradley

this is bad ... hopefully nobody cares about performance here.

@SparkQA
Copy link

SparkQA commented May 31, 2015

Test build #33844 has finished for PR 6536 at commit 633f9a1.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed May 31, 2015
View reviewed changes
examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala
Copy link
Contributor Author

@rxin rxin May 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mengxr @jkbradley

this is bad ... hopefully nobody cares about performance here.

Copy link
Member

@jkbradley jkbradley May 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. I'll make a note to remove it later.

@SparkQA
Copy link

SparkQA commented May 31, 2015

Test build #33845 has finished for PR 6536 at commit f833151.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 4b5f12b May 31, 2015
asfgit pushed a commit that referenced this pull request May 31, 2015
@rxin
[SPARK-7979] Enforce structural type checker.
01f38f7 
Author: Reynold Xin <[email protected]>

Closes #6536 from rxin/structural-type-checker and squashes the following commits:

f833151 [Reynold Xin] Fixed compilation.
633f9a1 [Reynold Xin] Fixed typo.
d1fa804 [Reynold Xin] [SPARK-7979] Enforce structural type checker.

(cherry picked from commit 4b5f12b)
Signed-off-by: Reynold Xin <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@rxin @jeanlyn
[SPARK-7979] Enforce structural type checker.
b2b4a0e 
Author: Reynold Xin <[email protected]>

Closes apache#6536 from rxin/structural-type-checker and squashes the following commits:

f833151 [Reynold Xin] Fixed compilation.
633f9a1 [Reynold Xin] Fixed typo.
d1fa804 [Reynold Xin] [SPARK-7979] Enforce structural type checker.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@rxin @nemccarthy
[SPARK-7979] Enforce structural type checker.
3409222 
Author: Reynold Xin <[email protected]>

Closes apache#6536 from rxin/structural-type-checker and squashes the following commits:

f833151 [Reynold Xin] Fixed compilation.
633f9a1 [Reynold Xin] Fixed typo.
d1fa804 [Reynold Xin] [SPARK-7979] Enforce structural type checker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @SparkQA @jkbradley