[SPARK-4782] Add inferSchema support for RDD[Map[String, Any]] #6554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or an RDD of a generic type T for which the user provides a mapping function from RDD[T] => RDD[Map[String,Any]]
Contributor
|
I don't know anything about this feature or patch, but as an outside observer I can say that this needs tests or at least a test to make sure that this feature doesn't get broken by future changes. |
|
Can one of the admins verify this patch? |
Contributor
|
Thanks for working on this @lucarosellini. Can we close this issue until you have time to bring it up to data and address the comments? |
Contributor
Author
|
@marmbrus sure, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we added a generic inferSchema method to allow schema infer for an RDD of a generic type T for which the user provides a mapping function from
RDD[T] => RDD[Map[String,Any]]