Skip to content

[SPARK-8020] Spark SQL in spark-defaults.conf make metadataHive get constructed too early #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yhuai wants to merge 3 commits into from
Closed

[SPARK-8020] Spark SQL in spark-defaults.conf make metadataHive get constructed too early #6563

yhuai wants to merge 3 commits into from

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Jun 1, 2015

@yhuai
Copy link
Contributor Author

yhuai commented Jun 1, 2015

cc @marmbrus

@marmbrus
Copy link
Contributor

marmbrus commented Jun 1, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33935 has finished for PR 6563 at commit bf766c6.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33930 has finished for PR 6563 at commit 0398f5b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33936 has finished for PR 6563 at commit 4e5addc.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jeanlyn
jeanlyn reviewed Jun 2, 2015
View reviewed changes
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
Copy link
Contributor

@jeanlyn jeanlyn Jun 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 12 equate to 0.12.0 or 1.2?

Copy link
Contributor Author

@yhuai yhuai Jun 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah (https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala#L49).

@asfgit asfgit closed this in 91f6be8 Jun 2, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@yhuai @jeanlyn
[SPARK-8020] Spark SQL in spark-defaults.conf make metadataHive get c…
d1624a4 
…onstructed too early

https://issues.apache.org/jira/browse/SPARK-8020

Author: Yin Huai <[email protected]>

Closes apache#6563 from yhuai/SPARK-8020 and squashes the following commits:

4e5addc [Yin Huai] style
bf766c6 [Yin Huai] Failed test.
0398f5b [Yin Huai] First populate the SQLConf and then construct executionHive and metadataHive.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@yhuai @nemccarthy
[SPARK-8020] Spark SQL in spark-defaults.conf make metadataHive get c…
9c406cf 
…onstructed too early

https://issues.apache.org/jira/browse/SPARK-8020

Author: Yin Huai <[email protected]>

Closes apache#6563 from yhuai/SPARK-8020 and squashes the following commits:

4e5addc [Yin Huai] style
bf766c6 [Yin Huai] Failed test.
0398f5b [Yin Huai] First populate the SQLConf and then construct executionHive and metadataHive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhuai @marmbrus @SparkQA @jeanlyn