[SPARK-8099] set executor cores into system in yarn-cluster mode #6643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuTingjun
changed the title
Member
|
This doesn't look like the right way to do it -- just manually setting a system property here? CC @tgravescs @sryza |
Contributor
|
I think the right place to fix this is probably https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L449. We probably want it to look like the line below that sets spark.executor.memory for all cluster managers. |
Contributor
Author
|
Thanks all, I have updated the code, please have a look again. |
Member
|
ok to test |
|
Test build #34259 has finished for PR 6643 at commit
|
Contributor
Author
|
please retest |
Member
|
Jenkins, retest this please |
|
Test build #34275 has finished for PR 6643 at commit
|
Member
|
@sryza if that's what you meant you can merge it |
Contributor
|
lgtm, great catch |
Contributor
|
LGTM, merging |
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
Author: Xutingjun <[email protected]> Author: xutingjun <[email protected]> Closes apache#6643 from XuTingjun/SPARK-8099 and squashes the following commits: 80b18cd [Xutingjun] change to STANDALONE | YARN ce33148 [Xutingjun] set executor cores into system e51cc9e [Xutingjun] set executor cores into system 0600861 [xutingjun] set executor cores into system
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Author: Xutingjun <[email protected]> Author: xutingjun <[email protected]> Closes apache#6643 from XuTingjun/SPARK-8099 and squashes the following commits: 80b18cd [Xutingjun] change to STANDALONE | YARN ce33148 [Xutingjun] set executor cores into system e51cc9e [Xutingjun] set executor cores into system 0600861 [xutingjun] set executor cores into system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.