-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-8018][MLlib]KMeans should accept initial cluster centers as param #6737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6959861
Accept initial cluster centers in KMeans
FlytxtRnD e9c35d7
Remove getInitialModel and match cluster count criteria
FlytxtRnD 16f1b53
Merge branch 'Kmeans-8018', remote-tracking branch 'upstream/master' …
FlytxtRnD cd5dc5c
Merge remote-tracking branch 'upstream/master' into Kmeans-8018
FlytxtRnD 3f5fc8e
test case modified and one runs condition added
FlytxtRnD 582e6d9
Merge remote-tracking branch 'upstream/master' into Kmeans-8018
FlytxtRnD 60c8ce2
ignore runs parameter and initialModel test suite changed
FlytxtRnD 714acb5
added numRuns
FlytxtRnD 242ead1
corrected == to === in assert
FlytxtRnD e721dfe
Merge remote-tracking branch 'upstream/master' into Kmeans-8018
FlytxtRnD 07f8554
remove setRuns from setIntialModel
FlytxtRnD d12336e
numRuns variable modifications
FlytxtRnD 06d13ef
numRuns corrected
FlytxtRnD c446c58
documentation and numRuns warning change
FlytxtRnD ef95ee2
style correction
FlytxtRnD 94b56df
style correction
FlytxtRnD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering out loud, don't know if this makes sense -- should the user have to supply a whole model just to specify initial centroids? or can they just specify the centroids here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srowen Thanks for the comments. We followed this approach based on @mengxr 's suggestion at https://issues.apache.org/jira/browse/SPARK-8018?focusedCommentId=14571757&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14571757. Please have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, that's fine.