Skip to content

[SPARK-8220][SQL]Add positive identify function #6838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhichao-li wants to merge 2 commits into from
Closed

[SPARK-8220][SQL]Add positive identify function #6838

zhichao-li wants to merge 2 commits into from

Conversation

@zhichao-li
Copy link
Contributor

@zhichao-li zhichao-li commented Jun 16, 2015

@zhichao-li zhichao-li changed the title Add positive identify function[WIP] [SPARK-8227][SQL]Add positive identify function[WIP] Jun 16, 2015
@zhichao-li zhichao-li changed the title [SPARK-8227][SQL]Add positive identify function[WIP] [SPARK-8220][SQL]Add positive identify function[WIP] Jun 16, 2015
chenghao-intel
chenghao-intel reviewed Jun 16, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala Outdated
Copy link
Contributor

@chenghao-intel chenghao-intel Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change data => child?

@SparkQA
Copy link

SparkQA commented Jun 16, 2015

Test build #34974 has finished for PR 6838 at commit 624d438.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class UnaryPositive(child: Expression) extends UnaryArithmetic

@zhichao-li zhichao-li changed the title [SPARK-8220][SQL]Add positive identify function[WIP] [SPARK-8220][SQL][WIP]Add positive identify function Jun 17, 2015
@SparkQA
Copy link

SparkQA commented Jun 17, 2015

Test build #35014 has finished for PR 6838 at commit e1032a0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class UnaryPositive(child: Expression) extends UnaryArithmetic

@chenghao-intel
Copy link
Contributor

chenghao-intel commented Jun 17, 2015

LGTM, can you remove the [WIP]? @rxin, can you review this one?

@zhichao-li zhichao-li changed the title [SPARK-8220][SQL][WIP]Add positive identify function [SPARK-8220][SQL]Add positive identify function Jun 17, 2015
rxin
rxin reviewed Jun 17, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
Copy link
Contributor

@rxin rxin Jun 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just name this Positive

@rxin
Copy link
Contributor

rxin commented Jun 17, 2015

actually i'm just going to merge this. UnaryPositiv vs Positive isn't that big of a deal here.

@asfgit asfgit closed this in bedff7d Jun 17, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@zhichao-li @nemccarthy
[SPARK-8220][SQL]Add positive identify function
05a9990 
chenghao-intel adrian-wang

Author: dragonli <[email protected]>
Author: zhichao.li <[email protected]>

Closes apache#6838 from zhichao-li/positive and squashes the following commits:

e1032a0 [dragonli] remove useless import and refactor code
624d438 [zhichao.li] add positive identify function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhichao-li @SparkQA @chenghao-intel @rxin